On Wed, May 30, 2018 at 7:12 AM, Robert Munteanu <[email protected]> wrote:
> Hi Dan,
>
> On Fri, 2018-05-25 at 10:46 -0400, Daniel Klco wrote:
> > Hey All,
> >
> > I've wrapped up all of the things I wanted to fix before releasing
> > the
> > first version of the Sling CMS Sample app.
>
> Awesome! Having a good reference app will be quite useful.
>
> >
> > I'm thinking of creating two repositories:
> >
> > - sling-org-apache-sling-cms <- the core CMS code
> > - sling-org-apache-sling-cms-reference <- the reference
> > application /
> > components so this can be versioned separately from the underlying
> > application
>
> How does this map to the folders from [1]?
>
I'd like to separate these out, but I think it makes more sense to keep
them together for the moment to keep the build simple since having the
reference app packaged into the CMS brings a lot of benefits.
>
> > Does this sound good? Should the names contain sample?
>
> IMO only if it's a sample. But this looks more like a proper
> application, so I would suggest differentiating the actual application
> with an 'app' prefix, e.g.
>
> org.apache.sling.app.reference-cms
>
> or something similar.
>
Sounds good. how about:
Repo Name: sling-org-apache-sling-app-cms
Artifact ID: org.apache.sling.app.cms
Artifact Name: Apache Sling - CMS Reference App
> BTW, you seem to have committed something called ${frontend.target}
> below [2].
>
Thanks! I've removed it. Looks like it was a bad mvn config.
> Thanks,
>
> Robert
>
> [1]: https://github.com/apache/sling-whiteboard/tree/master/cms
> [2]: https://github.com/apache/sling-whiteboard/tree/master/cms/reference
>
