rombert commented on a change in pull request #4: Provide name hints for SDI
configuration entries
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/4#discussion_r192000015
##########
File path: src/main/java/org/apache/sling/dynamicinclude/package-info.java
##########
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-@Version("4.0.0")
+@Version("4.0.1")
Review comment:
I think this was needed due to the fields added to `Configuration` being
package-private. Can you check after making them private if the version bump is
still needed? (It might be due to the annotation, in which case leave it as-is).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
