[ 
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497680#comment-16497680
 ] 

Stefan Seifert commented on SLING-7692:
---------------------------------------

bq. Do you think --force push on github would be reflected on gitbox? 
no, do not let play with changing our history

the current multi session support makes sense in a way and support serveral use 
cases already. you can create multiple sessions, and you can read and change 
data in all of them. they are just not isolated. this is much better then do 
not have support for multi sessions at all.
is see no problem in supporting refresh with keeping changes as it produces the 
desired result (although the changes from other changes where already visible 
before), but still code using it will run correct.
i makes sense to throw an exception when refresh without keeping changes is 
called.

> MockSession.revert(false) should be supported
> ---------------------------------------------
>
>                 Key: SLING-7692
>                 URL: https://issues.apache.org/jira/browse/SLING-7692
>             Project: Sling
>          Issue Type: Improvement
>          Components: Testing
>    Affects Versions: Testing JCR Mock 1.3.2
>            Reporter: Nicolas Peltier
>            Assignee: Nicolas Peltier
>            Priority: Major
>             Fix For: Testing JCR Mock 1.3.4
>
>
> MockSession does not cancel the changes when refresh(false) is called, hence 
> resolver.revert() not working in case JCR_MOCK is used



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to