rombert commented on issue #4: SLING-7630: Created the constructors so that non-OSGi containers can … URL: https://github.com/apache/sling-ide-tooling/pull/4#issuecomment-396577222 Looks good to me, thanks! I would only suggest that you add a comment to the no-arg constructors, something similar to "Used by declarative services implementation" to make it clear why we're keeping them.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
