rombert commented on issue #2: Upgraded oak to 1.8.3 + minor version bumps URL: https://github.com/apache/sling-org-apache-sling-starter/pull/2#issuecomment-396614133 Thanks for your patience @ieugen . The change looks good to me. We need to add a Jira reference to the commit message ( probably SLING-7446 ) but I'll do that since I already pestered you a lot for this PR :-) I asked for clarification on [SLING-7437](https://issues.apache.org/jira/browse/SLING-7437) since we may need changes there to support Oak 1.8. Once that is clear I'll merge the PR. On an unrelated note, your 'From' and 'Signed-off-by' emails are not the same. Not a problem for me, but maybe you did not intend that...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services