[ 
https://issues.apache.org/jira/browse/SLING-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511029#comment-16511029
 ] 

Christian Schneider commented on SLING-7612:
--------------------------------------------

The code basically does the same. There is no functional improvement. I hope it 
still makes sense to refactor old code from time to time to keep up with new 
design best practices.

> Use Declarative Services to register optional components
> --------------------------------------------------------
>
>                 Key: SLING-7612
>                 URL: https://issues.apache.org/jira/browse/SLING-7612
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>    Affects Versions: Commons Mime 2.1.10
>            Reporter: Christian Schneider
>            Priority: Major
>             Fix For: Commons Mime 2.1.12
>
>
> Currently the TikaMimeTypeProvider as well as the MimeTypeWebConsolePlugin 
> are registered programmatically. I guess this is done make sure they work 
> with the optional package dependencies.
> I recently learned that DS is very good to handle this case. So I propose to 
> do both with simple DS component annotations.
> See: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/2
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to