rombert opened a new pull request #8: SLING-7544 Make optimized alias lookup non-blocking URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/8 I've tried to simplify the async init logic somehow and make sure we use the same 'lock' to guard access everywhere. This is a follow of of #7 , trying a different approach. I still get a test failure though but I'm not sure if I read the test correctly ```[ERROR] Tests run: 39, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.251 s <<< FAILURE! - in org.apache.sling.resourceresolver.impl.mapping.MapEntriesTest [ERROR] test_doAddAliasWhileInitializing(org.apache.sling.resourceresolver.impl.mapping.MapEntriesTest) Time elapsed: 0.117 s <<< FAILURE! java.lang.AssertionError: expected null, but was:<{alias=child}> at org.apache.sling.resourceresolver.impl.mapping.MapEntriesTest.test_doAddAliasWhileInitializing(MapEntriesTest.java:1214) ``` @DominikSuess - can you clarify what the the above failing test validates? You added it in 04369d24b831b9e4c7881606b82d67d37fa829a7 but I am not 100% sure why you test this way.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
