On Thursday 14 June 2018 12:30:48 Ioan Eugen Stan wrote:
> Hello,

Hi,

> I've made some PR's for Sling Karaf related projects and I would like to
> ask for review/merge. Developing on top of Sling Started project is not
> the best experience and since I've learned more about Sling internals I
> decided to improve Karaf.
> 
> I would like to share my way of handling karaf related packages for easy
> development - it might be useful for other situations.
> 
> The problem that it solves for me is:
> 
> - Sling has a lot of repositories that keep each component in it's own
> repo. This is great for modularity and having a different version +
> history for that module however I have found it is not the best thing
> when you need to iterate fast and have it easy to build related packages.
> 
> My solution is to rely on git submodules and create an aggregator
> repository/project that adds and manages the related projects.
> 
> For something like Sling Karaf projects, it fits very nicely. I believe
> it might be good for other situations in Sling eco-system.
> 
> I have pushed this setup here [1].

our current solution is Google's repo. You can set up your own set of modules 
easily. For Sling Karaf see https://github.com/oliverlietz/sling-karaf-repo

> Also the PR's are available here [2] [3] and [4] .
> 
> I've seen that there is another PR that needs some TLC by Christian
> Schneider. I would like to help out with Karaf maintenance - it seems it
> could use some help. I would love to be able to do that as part of Sling
> project.

Your PRs are rather large and touch different scopes. Please be more focused 
and start a discussion on dev first or add issues to JIRA whenever an issue is 
not just a typo or javadoc fix.

Thanks,
O.

> Thanks,
> 
> Eugen
> 
> 
> [1] https://github.com/netdava/sling-org-apache-sling-karaf
> 
> [2] https://github.com/apache/sling-org-apache-sling-karaf-features/pull/2
> 
> [3]
> https://github.com/apache/sling-org-apache-sling-karaf-distribution/pull/1
> 
> [4] https://github.com/apache/sling-org-apache-sling-karaf-configs/pull/1
> 
> [5] https://github.com/apache/sling-org-apache-sling-karaf-features/pull/1

Reply via email to