rombert commented on issue #5: Feature/stop selector duplication URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/5#issuecomment-398399381 The change looks good to me @toniedzwiedz ! I like the way you extracted the reusable logic out and made it easily testable, that's always good. One suggestion that I would make is to move the `UrlBuilder` to an implementation package - this way we don't have to bump exported package versions and the project version at all. WDYT?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
