rombert commented on issue #8: SLING-7544 Make optimized alias lookup non-blocking URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/8#issuecomment-398412803 @DominikSuess - now I think I know what's going on. I changed the behaviour so that the `initLock` is released when the `aliasMap` is populated in an async manner, not when the `doInit` method exits. The `addResource` method (as intended) waits for the `initLock` to be available, and therefore always waits until the initialisation is complete, which means that the alias maps are now always populated in the test method you added. So my questions are: 1. Is my change conceptually correct and does it still keep the optimisation? 2. Do we need to alter the test you added in the last commit, maybe removing the `assertNull` call, or can we remove it altogether?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
