This has been out for a while with no one voicing a concern that we shouldn't change the default compiler and one person voicing that we shouldn't have a default at all.
I'm assuming that my next step would be to update the POM. Correct? - Jason On Thu, Jul 5, 2018, at 11:29 AM, Jason E Bailey wrote: > My concern with that, is that there are a number of modules that can be > thought of as the core Sling modules. If one of those gets updated > independently then Sling as a whole doesn't work unless you are running > the newest VM. > > By defaulting it to a parent POM, if you over ride it, there is a clear > indicator that you are going above and beyond what we are stating that > Sling as a whole requires. > > - Jason > > On Thu, Jul 5, 2018, at 11:17 AM, Konrad Windszus wrote: > > I would recommend to not provide a default compiler class version at > > all but rather force each inheriting module to set that explicitly via a > > property. There is even a Maven enforcer rule which makes Maven builds > > fail in case that property is not set. > > That way each module must define the compatibility on its own! > > Konrad > > > > Von meinem iPhone gesendet > > > > > Am 05.07.2018 um 17:11 schrieb Nicolas Peltier > > > <[email protected]>: > > > > > > isn't this also a removal of sling support for java 7 ? > > > leaving the option to compile with it does not help as soon as you get > > > java > > > 8 specificities > > > > > > i'm not saying i'm against it, just that it's not just a default language > > > level change, and we should be clearer if we do it > > > > > >> Le jeu. 5 juil. 2018 à 17:09, Jason E Bailey <[email protected]> a écrit : > > >> > > >> I'm proposing we update the parent pom so that JRE8 is the default > > >> compilation level. > > >> > > >> This should not break code except for extreme corner cases > > >> http://www.oracle.com/technetwork/java/javase/8-compatibility-guide-2156366.html > > >> > > >> This will provide access to language improvements that are in Java8 for > > >> all development. > > >> > > >> > > >> - Jason > > >> > >
