IIUC the two new methods of getMapping and getAllMappings will return either a path or a full URL depending on whether a HttpServletRequest is being passed. That's overloading a function to return two different things based on the existence of a parameter.
In my experience a method should do one thing and I disagree with that approach. - Jason On Wed, Aug 1, 2018, at 5:19 PM, Robert Munteanu wrote: > Hi, > > To fix $SUBJECT I created a draft API change PR at > > https://github.com/apache/sling-org-apache-sling-api/pull/6 > > Would appreciate as many eyes on the changes as possible. > > Thanks! > > Robert >
