[ https://issues.apache.org/jira/browse/SLING-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Seifert updated SLING-7798: ---------------------------------- Fix Version/s: Commons Messaging Mail 1.0.0 Commons Messaging 1.0.0 Description: follow-up from SLING-7312 and discussion from the [mailing list|https://lists.apache.org/thread.html/44cac2f3c9454a308b70adb9c73a8e9a928d9c145a12f82f8a3a0ef1@%3Cdev.sling.apache.org%3E]. i will also start a vote on the mailing list about this, but this ticket describes the steps that are required. about the jetbrains annotations: * documentation: [https://www.jetbrains.com/help/idea/nullable-and-notnull-annotations.html] * artifact: [http://repo1.maven.org/maven2/org/jetbrains/annotations/16.0.2/] * although from jetbrans created for IntelliJ, they are also support by most other tooling (e.g. findbugs, sonar, configurable in Eclipse) * apache 2.0 licensed: [https://github.com/JetBrains/java-annotations] this search turned out that these modules are currently using JSR-305 annotations and need to be converted: |org-apache-sling-api|(/)| |org-apache-sling-auth-core|(/) removed unused dependency| |org-apache-sling-caconfig-api|(/)| |org-apache-sling-caconfig-impl|(/)| |org-apache-sling-caconfig-spi|(/)| |org-apache-sling-commons-clam|(/)| |org-apache-sling-commons-messaging|(/) no release yet| |org-apache-sling-commons-messaging-mail|(/) no release yet| |org-apache-sling-discovery-commons|(/)| |org-apache-sling-distribution-api|(/)| |org-apache-sling-distribution-avro-serializer|(/) no release yet| |org-apache-sling-distribution-core|(/) unit test fails (already before)| |org-apache-sling-distribution-kryo-serializer|(/) no release yet| |org-apache-sling-installer-core|(/)| |org-apache-sling-jcr-api|(/)| |org-apache-sling-jcr-resource|(/)| |org-apache-sling-jms|(/)| |org-apache-sling-jobs|(/)| |org-apache-sling-jobs-it-services|(/) no release required| |org-apache-sling-models-api|(/)| |org-apache-sling-models-impl|(/)| |org-apache-sling-models-jacksonexporter|(/)| |org-apache-sling-models-validation-impl|(/)| |org-apache-sling-mom|(/)| |org-apache-sling-oak-restrictions|(/)| |org-apache-sling-resource-presence|(/)| |org-apache-sling-resourceresolver|(/)| |org-apache-sling-scripting-core|(/)| |org-apache-sling-scripting-sightly|(/)| |org-apache-sling-scripting-thymeleaf|(/)| |org-apache-sling-tracer|(/)| |org-apache-sling-validation-api|(/)| |org-apache-sling-validation-core|(/)| |org-apache-sling-validation-test-services|(/) no release required| |org-apache-sling-xss|(/)| |parent|(/)| |whiteboard/encrypt|(/) no release required| |whiteboard/project-archetype/src/main/resources/archetype-resources|(/) no release required| |whiteboard/scripting-resolver/org-apache-sling-scripting-resolver|(/) no release required| steps to do: # convert java sources and poms to jetbrains annotations and update package versions with the help of the {{convert-annotations.sh}} from OAK-7511 provided by [~reschke] described here # update sling documentation: [https://sling.apache.org/documentation/development/jsr-305.html] was: follow-up from SLING-7312 and discussion from the [mailing list|https://lists.apache.org/thread.html/44cac2f3c9454a308b70adb9c73a8e9a928d9c145a12f82f8a3a0ef1@%3Cdev.sling.apache.org%3E]. i will also start a vote on the mailing list about this, but this ticket describes the steps that are required. about the jetbrains annotations: * documentation: [https://www.jetbrains.com/help/idea/nullable-and-notnull-annotations.html] * artifact: [http://repo1.maven.org/maven2/org/jetbrains/annotations/16.0.2/] * although from jetbrans created for IntelliJ, they are also support by most other tooling (e.g. findbugs, sonar, configurable in Eclipse) * apache 2.0 licensed: [https://github.com/JetBrains/java-annotations] this search turned out that these modules are currently using JSR-305 annotations and need to be converted: |org-apache-sling-api|(/)| |org-apache-sling-auth-core|(/) removed unused dependency| |org-apache-sling-caconfig-api|(/)| |org-apache-sling-caconfig-impl|(/)| |org-apache-sling-caconfig-spi|(/)| |org-apache-sling-commons-clam|(/)| |org-apache-sling-commons-messaging|[~olli]| |org-apache-sling-commons-messaging-mail|[~olli]| |org-apache-sling-discovery-commons|(/)| |org-apache-sling-distribution-api|(/)| |org-apache-sling-distribution-avro-serializer|(/) no release yet| |org-apache-sling-distribution-core|(/) unit test fails (already before)| |org-apache-sling-distribution-kryo-serializer|(/) no release yet| |org-apache-sling-installer-core|(/)| |org-apache-sling-jcr-api|(/)| |org-apache-sling-jcr-resource|(/)| |org-apache-sling-jms|(/)| |org-apache-sling-jobs|(/)| |org-apache-sling-jobs-it-services|(/)| |org-apache-sling-models-api|(/)| |org-apache-sling-models-impl|(/)| |org-apache-sling-models-jacksonexporter|(/)| |org-apache-sling-models-validation-impl|(/)| |org-apache-sling-mom|(/)| |org-apache-sling-oak-restrictions|(/)| |org-apache-sling-resource-presence|(/)| |org-apache-sling-resourceresolver|(/)| |org-apache-sling-scripting-core|(/)| |org-apache-sling-scripting-sightly|(/)| |org-apache-sling-scripting-thymeleaf|(/)| |org-apache-sling-tracer|(/)| |org-apache-sling-validation-api|(/)| |org-apache-sling-validation-core|(/)| |org-apache-sling-validation-test-services|(/)| |org-apache-sling-xss|(/)| |parent|(/)| |whiteboard/encrypt|(/)| |whiteboard/project-archetype/src/main/resources/archetype-resources|TODO| |whiteboard/scripting-resolver/org-apache-sling-scripting-resolver|TODO| steps to do: # convert java sources and poms to jetbrains annotations and update package versions with the help of the {{convert-annotations.sh}} from OAK-7511 provided by [~reschke] described here # update sling documentation: [https://sling.apache.org/documentation/development/jsr-305.html] i've updated all listed modules - the script from [~reschke] worked very well in my envrionment, only small adjustment to poms or package version were nessecary here and there. [~olli] i've also updated sling-org-apache-sling-commons-messaging and sling-org-apache-sling-commons-messaging-mail as this was done by the script already. in most cases i've not updated the sling-parent dependency to 34 because this has more sid-effects (e.g. minimal java version 8). this decision should be done individually for each module. when the parent is updated the version of the jetbrains annotations dependency can be removed. > Switch from JSR-305 annotations to JetBrains Nullable/NotNull annotations > -------------------------------------------------------------------------- > > Key: SLING-7798 > URL: https://issues.apache.org/jira/browse/SLING-7798 > Project: Sling > Issue Type: Improvement > Components: General > Reporter: Stefan Seifert > Assignee: Stefan Seifert > Priority: Major > Fix For: JCR API 2.4.2, Auth Core 1.4.4, API 2.18.4, Sling Models > API 1.3.8, Content Distribution Core 0.3.0, Content Distribution API 0.4.0, > Validation API 1.0.2, Sling Models Validation Impl 1.0.0, Log Tracer 1.0.8, > Commons Messaging 1.0.0, Commons Messaging Mail 1.0.0, Scripting Thymeleaf > 2.0.0, Oak Restrictions 1.0.2, Context-Aware Configuration API 1.1.2, MoM API > 1.0.2, MoM JMS 1.0.2, MoM Jobs 1.0.2, Resource Presence 0.0.4, Discovery > Commons 1.0.22, Context-Aware Configuration SPI 1.3.4, Sling Models Jackson > Exporter 1.0.10, Validation Core 1.0.6, Parent 34, Scripting Core 2.0.56, > Installer Core 3.8.14, Sling Models Impl 1.4.10, Context-Aware Configuration > Impl 1.4.14, Commons Clam 1.0.0, Resource Resolver 1.6.6, JCR Resource > 3.0.16, XSS Protection API 2.0.14, Scripting HTL Engine 1.0.56-1.4.0 > > > follow-up from SLING-7312 and discussion from the [mailing > list|https://lists.apache.org/thread.html/44cac2f3c9454a308b70adb9c73a8e9a928d9c145a12f82f8a3a0ef1@%3Cdev.sling.apache.org%3E]. > i will also start a vote on the mailing list about this, but this ticket > describes the steps that are required. > about the jetbrains annotations: > * documentation: > [https://www.jetbrains.com/help/idea/nullable-and-notnull-annotations.html] > * artifact: [http://repo1.maven.org/maven2/org/jetbrains/annotations/16.0.2/] > * although from jetbrans created for IntelliJ, they are also support by most > other tooling (e.g. findbugs, sonar, configurable in Eclipse) > * apache 2.0 licensed: [https://github.com/JetBrains/java-annotations] > this search turned out that these modules are currently using JSR-305 > annotations and need to be converted: > |org-apache-sling-api|(/)| > |org-apache-sling-auth-core|(/) removed unused dependency| > |org-apache-sling-caconfig-api|(/)| > |org-apache-sling-caconfig-impl|(/)| > |org-apache-sling-caconfig-spi|(/)| > |org-apache-sling-commons-clam|(/)| > |org-apache-sling-commons-messaging|(/) no release yet| > |org-apache-sling-commons-messaging-mail|(/) no release yet| > |org-apache-sling-discovery-commons|(/)| > |org-apache-sling-distribution-api|(/)| > |org-apache-sling-distribution-avro-serializer|(/) no release yet| > |org-apache-sling-distribution-core|(/) unit test fails (already before)| > |org-apache-sling-distribution-kryo-serializer|(/) no release yet| > |org-apache-sling-installer-core|(/)| > |org-apache-sling-jcr-api|(/)| > |org-apache-sling-jcr-resource|(/)| > |org-apache-sling-jms|(/)| > |org-apache-sling-jobs|(/)| > |org-apache-sling-jobs-it-services|(/) no release required| > |org-apache-sling-models-api|(/)| > |org-apache-sling-models-impl|(/)| > |org-apache-sling-models-jacksonexporter|(/)| > |org-apache-sling-models-validation-impl|(/)| > |org-apache-sling-mom|(/)| > |org-apache-sling-oak-restrictions|(/)| > |org-apache-sling-resource-presence|(/)| > |org-apache-sling-resourceresolver|(/)| > |org-apache-sling-scripting-core|(/)| > |org-apache-sling-scripting-sightly|(/)| > |org-apache-sling-scripting-thymeleaf|(/)| > |org-apache-sling-tracer|(/)| > |org-apache-sling-validation-api|(/)| > |org-apache-sling-validation-core|(/)| > |org-apache-sling-validation-test-services|(/) no release required| > |org-apache-sling-xss|(/)| > |parent|(/)| > |whiteboard/encrypt|(/) no release required| > |whiteboard/project-archetype/src/main/resources/archetype-resources|(/) no > release required| > |whiteboard/scripting-resolver/org-apache-sling-scripting-resolver|(/) no > release required| > steps to do: > # convert java sources and poms to jetbrains annotations and update package > versions with the help of the {{convert-annotations.sh}} from OAK-7511 > provided by [~reschke] described here > # update sling documentation: > [https://sling.apache.org/documentation/development/jsr-305.html] -- This message was sent by Atlassian JIRA (v7.6.3#76005)