Hi Stefan, My understanding of the ConsumerType/ProviderType is that it's a ConsumerType if the object is meant to be consumed and a ProviderType if it's meant to be implemented by another bundle to add or extend the functionality. Along the lines of ProviderType ~= Service Provider Interface.
These are meant to be consumed. As for marking classes final, I don't mark a class final unless there is a clear need to mark the class final. My lack of understanding someone else's use case for extending one of my classes is not sufficient enough reason for me to do that. - Jason On Sun, Sep 2, 2018, at 5:24 PM, Stefan Seifert wrote: > hello jason. > > one last formal comment on the API of this module (sorry for coming up > with it so late): > - the API classes/interfaces should be annotated with the OSGi > ProviderType/ConsumerType annotations > - it looks for me they all should be applied with ProviderType > - perhaps the classes ResourceFilterStream and ResourceStream should be > declared final, unless they are explicitly designed for extension by > subclassing > > stefan > > >-----Original Message----- > >From: Jason E Bailey [mailto:[email protected]] > >Sent: Sunday, September 2, 2018 10:02 PM > >To: [email protected] > >Subject: [VOTE] Initial Release of Apache Sling Resource Filter version > >1.0.0 > > > >Hi, > > > >We solved 1 issue in this release: > >https://issues.apache.org/jira/projects/SLING/versions/12343798 > > > >Staging repository: > >https://repository.apache.org/content/repositories/orgapachesling-1952/ > > > >You can use this UNIX script to download the release and verify the > >signatures: > >https://gitbox.apache.org/repos/asf?p=sling-tooling- > >release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > >Usage: > >sh check_staged_release.sh 1952 /tmp/sling-staging > > > >Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > >This majority vote is open for at least 72 hours. > > > >- Jason >
