JEBailey commented on issue #7: create MissingElementsException only if there is at least one missing element URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/7#issuecomment-418717956 In a somewhat similar way, you're replacing the creation of one object that isn't used with a creation of another object that isn't used. Although I'm not a fan of null checks, it would be more overall efficient if the initial object is nulled and then a check performed for the null prior to adding an exception. Lazy creation.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
