npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes
URL:
https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216231612
##########
File path: src/main/java/org/apache/sling/pipes/PipeBuilder.java
##########
@@ -252,6 +253,16 @@
description = "read multi property, and output each value in the
bindings")
PipeBuilder mp();
+ /**
+ * attach an ACL pipe to the current context
+ * @param conf configuration parameters
+ * @return updated instance of PipeBuilder
+ * @throws IllegalAccessException in case it's called with bad
configuration
+ */
+ @PipeExecutor(command = "acls", resourceType = ACLPipe.RESOURCE_TYPE,
pipeClass = ACLPipe.class,
+ description = "sets acls on the resource or output each acls on
the resource or acls for authorizable in repository in bindings")
+ PipeBuilder acls(Object... conf) throws IllegalAccessException;
Review comment:
i think that the following is more appropriate as discussed:
- allow(String expr),
- deny(String expr),
- acls()
allow or deny will internally set your allow & deny flag
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
