npeltier commented on issue #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#issuecomment-419953661 we are almost there @dichaudh ! - pls remove the trailing space in pom - fix javadoc for acl pipe `mvn javadoc:javadoc` returns for it [0] - more importantly, once you did the above, squash the commits to one commit with meaningfull message, so i don't have to do it myself and lose your name and contribution in doing so. [0] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:javadoc (default-cli) on project org.apache.sling.pipes: An error has occurred in Javadoc report generation: [ERROR] Exit code: 1 - /Users/npeltier/Documents/git/github/apache/sling-aggregator/org-apache-sling-pipes/src/main/java/org/apache/sling/pipes/internal/ACLPipe.java:169: error: @param name not found [ERROR] * @param authorizable current resource as an authorizable [ERROR] ^ [ERROR] /Users/npeltier/Documents/git/github/apache/sling-aggregator/org-apache-sling-pipes/src/main/java/org/apache/sling/pipes/internal/ACLPipe.java:172: warning: no @param for auth [ERROR] protected void bindAclsForAuthorizableResource(Authorizable auth) throws RepositoryException { [ERROR] ^ [ERROR] /Users/npeltier/Documents/git/github/apache/sling-aggregator/org-apache-sling-pipes/src/main/java/org/apache/sling/pipes/internal/ACLPipe.java:172: warning: no @throws for javax.jcr.RepositoryException [ERROR] protected void bindAclsForAuthorizableResource(Authorizable auth) throws RepositoryException { [ERROR] ^ [ERROR] /Users/npeltier/Documents/git/github/apache/sling-aggregator/org-apache-sling-pipes/src/main/java/org/apache/sling/pipes/internal/ACLPipe.java:211: warning: no @return [ERROR] protected Principal getPrincipalFor(String prinicipalName) { [ERROR] ^ [ERROR] /Users/npeltier/Documents/git/github/apache/sling-aggregator/org-apache-sling-pipes/src/main/java/org/apache/sling/pipes/internal/ACLPipe.java:90: warning: no @param for upperBindings [ERROR] public ACLPipe(Plumber plumber, Resource resource, PipeBindings upperBindings) throws Exception {
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
