[ 
https://issues.apache.org/jira/browse/SLING-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610800#comment-16610800
 ] 

Robert Munteanu edited comment on SLING-7913 at 9/11/18 3:33 PM:
-----------------------------------------------------------------

The "ban" would be enforced at build-time only. Integration testing would be 
possible either by deploying the artifact using the OSGi console/JCR installer 
or by skipping the enforcer plug-in configuration.

We previously had SNAPSHOT versions in the starter and it was (IMO) a pain:

- builds were not reproducible
- Starter releases were hard since we had to either roll-back (and miss out on 
bugfixes) or release (which took a long time for dozens of modules)
- releases themselves were hard to manage in the starter
  -- initially we had version X.Y.Z-SNAPSHOT in the starter
  -- for the release, we moved to X.Y.(Z+2)-SNAPSHOT since the older SNAPSHOT 
was deleted by Nexus
  -- after the release we moved to the released X.Y.Z+1
  -- for the first change we moved to X.Y.(Z+2)-SNAPSHOT

My answer to testing problems would be to make it easier to test the starter 
with a certain SNAPSHOT and also to automatically run it for pull requests.


was (Author: rombert):
The "ban" would be enforced at build-time only. Integration testing would be 
possible either by deploying the artifact using the OSGi console/JCR installer 
or by skipping the enforcer plug-in configuration.

We previously had SNAPSHOT versions in the starter and it was (IMO) a pain:

- builds were not reproducible
- Starter releases were hard since we had to either roll-back (and miss out on 
bugfixes) or release (which took a long time for dozens of modules)
- releases themselves were hard to manage in the starter
  - initially we had version X.Y.Z-SNAPSHOT in the starter
  - for the release, we moved to X.Y.(Z+2)-SNAPSHOT since the older SNAPSHOT 
was deleted by Nexus
  - after the release we moved to the released X.Y.Z+1
  - for the first change we moved to X.Y.(Z+2)-SNAPSHOT

My answer to testing problems would be to make it easier to test the starter 
with a certain SNAPSHOT and also to automatically run it for pull requests.

> Ban snapshots in the Sling starter
> ----------------------------------
>
>                 Key: SLING-7913
>                 URL: https://issues.apache.org/jira/browse/SLING-7913
>             Project: Sling
>          Issue Type: Bug
>          Components: Starter
>            Reporter: Robert Munteanu
>            Priority: Major
>             Fix For: Starter 11
>
>
> We have agreed to keep only releases in the Sling starter to make it easier 
> to release and to make builds reproducible.
> We should enforce this policy to make it impossible to mistakenly add 
> SNAPSHOT versions to the project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to