simonetripodi commented on issue #4: SLING-7941 - Use streaming APIs to 
marshall the Feature to JSON
URL: 
https://github.com/apache/sling-org-apache-sling-feature-io/pull/4#issuecomment-425024554
 
 
   hi there @bosschaert ,
   unfortunately once fixed the rebase, there is an API conflict between 
`Feature#getInclude()` and `Feature#getIncludes()`, then between 
`JSONConstants.FEATURE_INCLUDE` and `JSONConstants.FEATURE_INCLUDEs`
   
   my IDE suggest me, once pulled and re-installed the SNAPSHOT version of 
`org.apache.sling.feature`, to use `Feature#getIncludes()` but `master` still 
uses the singular one, i.e. 
https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/test/java/org/apache/sling/feature/io/json/FeatureJSONWriterTest.java#L86
   
   What's the correct version?
   
   Conflicts are detected also on the _Writer_ counterpart, still about 
_Include(s)_
   
   TIA!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to