[
https://issues.apache.org/jira/browse/SLING-7941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630052#comment-16630052
]
ASF GitHub Bot commented on SLING-7941:
---------------------------------------
simonetripodi commented on issue #4: SLING-7941 - Use streaming APIs to
marshall the Feature to JSON
URL:
https://github.com/apache/sling-org-apache-sling-feature-io/pull/4#issuecomment-425024554
hi there @bosschaert ,
unfortunately once fixed the rebase, there is an API conflict between
`Feature#getInclude()` and `Feature#getIncludes()`, then between
`JSONConstants.FEATURE_INCLUDE` and `JSONConstants.FEATURE_INCLUDEs`
my IDE suggest me, once pulled and re-installed the SNAPSHOT version of
`org.apache.sling.feature`, to use `Feature#getIncludes()` but `master` still
uses the singular one, i.e.
https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/test/java/org/apache/sling/feature/io/json/FeatureJSONWriterTest.java#L86
What's the correct version?
Conflicts are detected also on the _Writer_ counterpart, still about
_Include(s)_
TIA!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use streaming APIs to serialize a Feature to the related JSON representation
> ----------------------------------------------------------------------------
>
> Key: SLING-7941
> URL: https://issues.apache.org/jira/browse/SLING-7941
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
> Affects Versions: Feature Model IO 0.1.4
> Reporter: Simone Tripodi
> Assignee: David Bosschaert
> Priority: Major
>
> We can avoid the unnecessary intermediate JSON objects creation by replacing
> current usage with {{javax.json.JsonGenerator}} APIs, when serializing a
> {{Feature}} to the related JSON representation.
> Pull request is coming, tests keep working as before.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
