[
https://issues.apache.org/jira/browse/SLING-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635106#comment-16635106
]
ASF GitHub Bot commented on SLING-7968:
---------------------------------------
bosschaert commented on issue #1: SLING-7968: Use FeatureProvider instead of
ArtifactManager.
URL:
https://github.com/apache/sling-org-apache-sling-feature-modelconverter/pull/1#issuecomment-426178399
Interestingly enough I came across a similar situation when working on the
API Whitelisting. In my case I need to map an Artifact (or ArtifactId) to
something like an InputStream or File.
If we refactor the FeatureProvider to a more general ArtifactProvider that
returns an InputStream we might be able to use the same interface for multiple
use-cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> FeatureModelConverter should use FeatureProvider instead of ArtifactManager
> ---------------------------------------------------------------------------
>
> Key: SLING-7968
> URL: https://issues.apache.org/jira/browse/SLING-7968
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
> Affects Versions: Slingstart Maven Plugin 1.8.2, Feature Model Converter
> 0.1.2
> Reporter: Karl Pauls
> Priority: Major
> Fix For: Feature Model Converter 0.1.4, Slingstart Maven Plugin
> 1.8.4
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The feature model converter currently requires an ArtifactManager. This is
> not needed and can be replaced with the less powerful FeatureProvider.
> Subsequently, we can use the simpler interface to actually use the maven
> resolver to resolve features in the Slingstart Maven Plugin (instead of using
> a ArtifactManager when invoking the model convert.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
