[
https://issues.apache.org/jira/browse/SLING-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643699#comment-16643699
]
Alexander Klimetschek commented on SLING-7429:
----------------------------------------------
I would be very careful here risking any backwards incompatibility - even if at
first sight 2. sounds like a feature that has no real purpose. You never know
what folks might be doing and often just accidentally relying on such a
behaviour.
IIUC, you are proposing to turn this around and on empty string select all
dictionaries with no basename set or set to an empty string. What would be the
use case for that? (I read the link but it just talks about the IT tests)
If this is really needed, I would prefer if we come up with a new way that does
not break BC. For example, define a new string name that we can be sure is not
used, for example „__sling_basename_all_unset“ or something like that. If we
don’t want to change the Java API and introduce another method parameter...
> Improve basename handling
> -------------------------
>
> Key: SLING-7429
> URL: https://issues.apache.org/jira/browse/SLING-7429
> Project: Sling
> Issue Type: Improvement
> Components: i18n
> Affects Versions: i18n 2.5.12
> Reporter: Konrad Windszus
> Priority: Major
>
> Right now the basename handling according to
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html#resourcebundle-with-base-names
> is as follows
> {quote}
> The base name argument can take one three values:
> # {{null}}, selects messages of mix:language nodes ignoring the existence or
> absence of sling:basename properties
> # Empty String, selects messages of mix:language nodes which have
> sling:basename properties, ignoring the actual values
> # Any other Value, selects messages of mix:language nodes whose
> sling:basename properties has any value which matches the base name string
> {quote}
> I think it should somehow be also possible for a client to explicitly select
> a resource bundle which is not having the {{sling:basename}} property set.
> This was originally triggered from
> https://issues.apache.org/jira/browse/SLING-7421?focusedCommentId=16335686&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16335686.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
