tmaret commented on a change in pull request #12: SLING-7754: implementation of Resource Based Queues URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/12#discussion_r224243603
########## File path: src/main/java/org/apache/sling/distribution/queue/impl/DistributionQueueProviderFactory.java ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.sling.distribution.queue.impl; + +public interface DistributionQueueProviderFactory { Review comment: IIUC, the API (although internal) is meant to abstract various implementations of queue providers, by default the historical Sling Jobs based one and the new queue implementation. The need for the API makes sense, but the API may leak some details from the new queue implementation, the serviceName and requirement to release a cleanup thread. I suggest to modify the API and implementation a little bit, such that the API fits the factory concept. The `DistributionQueueProviderFactory` would only contain the signature ``` DistributionQueueProvider getProvider(String agentName); ``` Instead of registering one `ResourceQueueCleanupTask` per queue, we'd register a single `ResourceQueueCleanupTask` to cleanup all queues. Registration and unregistration would be done via the `ResourceQueueProviderFactory` service either by registering/unregistering the cleanupTask service explicitly (as it is done now via the activate/deactivate methods) or by letting the `ResourceQueueProviderFactory` implements `Runnable` and schedule it using the whiteboard pattern. The `ResourceQueueCleanupTask` would use the QUEUES_ROOT as entry point instead of a agent queue path. The session performing the cleanup in `ResourceQueueCleanupTask` would be obtained via ``` resolverFactory.getServiceResourceResolver(null); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
