On Fri, 2018-10-12 at 10:20 +0200, Konrad Windszus wrote: > Hi Robert, > where in the check script do we actually check for that? > I only see checks for checksums and signatures in > https://github.com/apache/sling-tooling-release/blob/master/check_staged_release.sh > < > https://github.com/apache/sling-tooling-release/blob/master/check_staged_release.sh > >. > Could we add that check to the script if source release zip is > mandatory?
Ah, that was one of my extra check scripts :-) I have a script that unzips the source-release.zip file and builds the module. I have not added it to the release repository since it can fail with multiple modules in a single release is they depend on each other. But I guess it's a good idea to check the -source-release.zip as well, that's the main deliverable. https://issues.apache.org/jira/browse/SLING-8009 I don't have time to look into it right now, if anyone wants to give it a shot they're more than welcome :-) Thanks, Robert > > Thanks, > Konrad > > > On 11. Oct 2018, at 16:38, Robert Munteanu <[email protected]> > > wrote: > > > > Hi Georg, > > > > On Wed, 2018-10-10 at 21:38 +0200, Georg Henzler wrote: > > > Staging repository: > > > > > > > https://repository.apache.org/content/repositories/orgapachesling-1992 > > > > I don't see a source release at [1], and the check script seems to > > agree. > > > > Robert > > > > [1]: > > https://repository.apache.org/content/repositories/orgapachesling-1992/org/apache/sling/org.apache.sling.installer.provider.installhook/1.0.0/ > > > >
