[ https://issues.apache.org/jira/browse/SLING-7815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650205#comment-16650205 ]
Robert Munteanu commented on SLING-7815: ---------------------------------------- [~kwin], [~Csaba Varga] - I this is out of my area of expertise, I only noticed it breaks some things so I reverted it :-) If the changes look go to Konrad and the unit tests + Sling ITs pass, I'm +1 on merging this. > CLONE - ResourceResolver.clone(null) should not share the same JCR session > -------------------------------------------------------------------------- > > Key: SLING-7815 > URL: https://issues.apache.org/jira/browse/SLING-7815 > Project: Sling > Issue Type: Improvement > Components: API, JCR, ResourceResolver > Affects Versions: JCR Resource 3.0.14 > Reporter: Alexander Klimetschek > Assignee: Carsten Ziegeler > Priority: Major > Fix For: JCR Resource 3.0.18 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > {{ResourceResolver.clone()}} will reuse the same JCR session in case it was > created by passing an existing session using > {{JcrResourceConstants.AUTHENTICATION_INFO_SESSION}}. If you need a clone of > the resource resolver to pass into a new, separate thread, and use > {{ResourceResolver.clone(null)}}, you will actually share the session, but > this is not obvious. The problem is that a JCR session cannot be shared > across threads. > The javadocs of clone() say "the same credential data is used as was used to > create this instance". > There are a few problems with this: > - seeing the session object itself as "credential data" is unintuitive > - in my code, I have no idea what the original credential data was, so I > don't know what kind of credential data it was to make the right decision > - since sharing a JCR session is to be avoided at all times, the resource > resolver should prevent one from this > A solution would be if a plain {{ResourceResolver.clone(null)}} would return > a session that impersonated itself, abstracting this from the resource > resolver user. Additionally, it might be worth looking that clone always > returns a new session, unless specifically stated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)