paul-bjorkstrand commented on issue #6: SLING-7586 - using weak references as cache values to avoid memory leak URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/6#issuecomment-430034300 @justinedelson , after seeing https://github.com/Adobe-Marketing-Cloud/asset-share-commons/issues/177 I believe we need a combination of your approach, using `WeakReference` to solve the issue of indirect self referencing, and the addition of using `WeakHashMap` for the inner `Map` instances to completely solve the issue. When I first looked through the code above, I was unable to see the type of issue you were trying to solve. Reading that other ticket on asset-share-commons (and running into the issue in my environment) gave me a clearer understanding of the full issue..
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
