[
https://issues.apache.org/jira/browse/SLING-8003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653435#comment-16653435
]
ASF GitHub Bot commented on SLING-8003:
---------------------------------------
simonetripodi commented on issue #7: SLING-8003 - Interpolate Maven variables
using the Maven Filtering APIs rather that iterate string replacing operations
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/7#issuecomment-430602119
@bosschaert confirmed by Maven developers that there is no way to
interpolate indexed properties - the proposed interpolation is anyway more
robust than plain string replacing (which iterates over the whole file anyway).
Submitted test demonstrated anyway compatibility with current approach and
correct variables interpolation, is there anything that prevents to have this
merged? TIA! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Interpolate Maven variables using the Maven Filtering APIs rather that
> iterate string replacing operations
> ----------------------------------------------------------------------------------------------------------
>
> Key: SLING-8003
> URL: https://issues.apache.org/jira/browse/SLING-8003
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
> Reporter: Simone Tripodi
> Assignee: David Bosschaert
> Priority: Major
>
> Currently, the {{Substitution}} class iterates over all variables and replace
> them one by one in the whole input string.
> We can improve performances - and avoid writing custom variables interpolator
> - by replacing its use with the {{MavenReaderFilter}} API.
> It will helpful also to avoid reading the Feature file and storing it in a
> String, but keep working with {{Reader}} APIs.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
