+1 - Andrei
On Mon, Oct 22, 2018, 22:44 <dav...@apache.org> wrote: > +1 > > David Bosschaert > > On Mon, 22 Oct 2018 at 15:10, Georg Henzler <slin...@ghenzler.de> wrote: > > > Hi all, > > > > to follow up on this conversation I would like to start a vote from > > Sling side to give green light for the move of Health Checks to Felix > > [1]. The Felix project has expressed interest [2]. > > > > Please vote to approve the move: > > > > [ ] +1 Approve the move > > [ ] 0 Don't care > > [ ] -1 I have concerns, in particular... > > > > This majority vote is open for at least 72 hours. > > > > -Georg > > > > [1] > > https://issues.apache.org/jira/browse/SLING-7980 > > https://issues.apache.org/jira/browse/FELIX-5952 > > > > [2] > > https://www.mail-archive.com/dev@felix.apache.org/msg46780.html > > > > > > On 2018-10-11 16:17, Georg Henzler wrote: > > > Hi Bertrand, > > > > > >> Maybe I missed something but I do not see agreement on a concrete plan > > >> here so IMO the move is premature. > > > > > > I had the feeling that there was an agreement that it is definitely > > > good to move the health checks to felix to make them available to a > > > larger audience, maybe there wasn't a clear agreement on how to do > > > this exactly yet, but I think we get closer to this. > > > > > >> 1) How do we keep compatibility so that Sling users can use the Felix > > >> HCs in the future... > > > > > > There is a clear path on how to migrate (replace api dependency and > > > search and replace over java import statements replacing sling.hc.api > > > with felix.hc.api). The version as attached to FELIX-5952 fully > > > supports the HC API as well without having it as dependency (see [1] > > > for details) - this means that all health checks that exist out there > > > work without change. However the next release of sling.hc.api should > > > deprecate it so everyone that upgrades gets the messages to use the > > > Felix API instead of the Sling API (I created [2] for it). > > > > > >> ... without ending up with two distinct projects each > > >> with their own smaller fractured community > > > > > > Deprecation of the Sling HC API and a clear migration path will not > > > fracture the community I believe... rather having the HC API in Felix > > > will allow all users/projects on the Felix platform to use it (e.g. > > > ServiceMix projects) > > > > > >> 2) How can Sling committers maintain the module once it moves to > > >> Felix, is the Felix PMC open to give us write access to it? > > > > > > I think the Felix community is open to invite people for it [3] > > > > > >> 3) What's the plan w.rt. merging with the systemready module > > > > > > I agree with Christian here [4] that systemready can be implemented as > > > health check (once some minor improvements have been made to the > > > current API) > > > > > >> Before this is defined and agreed upon, I think a move is premature > > >> and likely to end up with two distinct modules and communities. > > > > > > I really want to avoid this as well! > > > > > > -Georg > > > > > > > > > [1] > > > > > > https://issues.apache.org/jira/browse/FELIX-5952?focusedCommentId=16643281&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16643281 > > > [2] https://issues.apache.org/jira/browse/SLING-7980 > > > [3] > > > > > > https://lists.apache.org/thread.html/974b95a91e3d4f2e5ba3aec1f04a85eb2adf65d80e24ea78287284af@%3Cdev.felix.apache.org%3E > > > > > > [4] > > > From > > > > > > https://lists.apache.org/thread.html/2a10823b9e8304c175cd1c8724d8903b04d4a5640e3e5e85e97a2fc7@%3Cdev.felix.apache.org%3E > > > > > >> As sling hc is a lot more mature and battle proven I can imagine to > > >> move to > > >> this basic framework and change the system ready checks to this API. > > >
