simonetripodi commented on a change in pull request #14: Issue/sling 8038
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/14#discussion_r227787130
##########
File path:
src/main/java/org/apache/sling/feature/maven/mojos/AbstractRepositoryMojo.java
##########
@@ -65,7 +65,12 @@
@Override
public void execute() throws MojoExecutionException, MojoFailureException {
- final File artifactDir = new
File(this.project.getBuild().getDirectory(), repositoryDir);
+ final File artifactDir ;
Review comment:
I have another suggestion here, in order to let Maven doing his job already:
```@Parameter(defaultValue = "${project.build.directory}/artifacts",
property = "repositoryDir")
private File artifactDir;``` since Maven is able already to interpolate
variables and automatically convert types.
Then, dropping `String repositoryDir` declaration and `File artifactDir`
building.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
