[ 
https://issues.apache.org/jira/browse/SLING-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665552#comment-16665552
 ] 

ASF GitHub Bot commented on SLING-7752:
---------------------------------------

andreituicu edited a comment on issue #2: SLING-7752 - Deserializing and 
serializing a feature model file suffles the configurations
URL: 
https://github.com/apache/sling-org-apache-sling-feature/pull/2#issuecomment-433510191
 
 
   @bosschaert Thank you very much! :) I'll keep the rebasing in mind for 
future PRs. Some developers prefer merging the master because it doesn't 
require a `git push --force` and others prefer the rebasing, because of the 
cleaner git history.
   Also, I hope this helps in the future: Github should have a merging option 
that allows the developer who merges the PR to squash the commits and can also 
change the title of the commit that makes it in the master with a single click.
   
https://help.github.com/articles/about-pull-request-merges/#squash-and-merge-your-pull-request-commits

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Deserializing and serializing a feature model file suffles the configurations
> -----------------------------------------------------------------------------
>
>                 Key: SLING-7752
>                 URL: https://issues.apache.org/jira/browse/SLING-7752
>             Project: Sling
>          Issue Type: Bug
>          Components: Feature Model
>            Reporter: Andrei Tuicu
>            Priority: Major
>             Fix For: Feature Model IO 0.1.4
>
>
> h3. Problem
> Deserializing and serializing a feature model file suffles the 
> configurations. This happens, because unordered maps (HashMaps/Hashtables) 
> are used in the implementations. The problem is relevant in the context of 
> adding these files in code versioning systems, because a minor change to a 
> file, done in an automated fashion, produces a big diff in the versioning 
> system and it becomes very hard to see exactly what is the relevant change. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to