[ 
https://issues.apache.org/jira/browse/SLING-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert updated SLING-8076:
------------------------------------
    Description: 
When feature model extensions are merged via 
BuilderUtil.mergeExtensions(Feature, Feature,
 ArtifactMerge, BuilderContext) any merge extensions are only invoked when the 
second extension instance is being merged. The first extension is simply copied 
into the target. 

However the Merge Handler may also need to perform some action on the first 
copy, for example record what feature the extension came from. This is 
currently not possible.

Proposal is to also call the Merge Handlers for the first merge (which is 
currently just a copy), so that they can also act in these cases.

  was:
When feature model extensions are merged via 
{{BuilderUtil.mergeExtensions(Feature, Feature,
ArtifactMerge, BuilderContext)}} any merge extensions are only invoked when the 
second extension instance is being merged. The first extension is simply copied 
into the target. 

However the Merge Handler may also need to perform some action on the first 
copy, for example record what feature the extension came from. This is 
currently not possible.

Proposal is to also call the Merge Handlers for the first merge (which is 
currently just a copy), so that they can also act in these cases.


> Merge Handlers should also be called on the first extension being merged in
> ---------------------------------------------------------------------------
>
>                 Key: SLING-8076
>                 URL: https://issues.apache.org/jira/browse/SLING-8076
>             Project: Sling
>          Issue Type: Bug
>          Components: Feature Model
>    Affects Versions: Feature Model 0.2.0
>            Reporter: David Bosschaert
>            Priority: Major
>             Fix For: Feature Model 0.2.2
>
>
> When feature model extensions are merged via 
> BuilderUtil.mergeExtensions(Feature, Feature,
>  ArtifactMerge, BuilderContext) any merge extensions are only invoked when 
> the second extension instance is being merged. The first extension is simply 
> copied into the target. 
> However the Merge Handler may also need to perform some action on the first 
> copy, for example record what feature the extension came from. This is 
> currently not possible.
> Proposal is to also call the Merge Handlers for the first merge (which is 
> currently just a copy), so that they can also act in these cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to