bosschaert commented on a change in pull request #2: SLING-8077 - refactor
ContentorderMergeProcessor to MergeHandler adju…
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/2#discussion_r231129960
##########
File path:
src/main/java/org/apache/sling/feature/extension/content/ContentOrderMergeProcessor.java
##########
@@ -51,6 +51,9 @@ public boolean canMerge(Extension extension) {
@Override
public void merge(HandlerContext context, Feature target, Feature source,
Extension targetEx, Extension sourceEx) {
+ if (target == null) {
+ return;
Review comment:
Sorry - I was wrong. Instead of just returning, it should be:
```
if (target == null) {
target.getExtensions().add(sourceEx)
return;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
