[
https://issues.apache.org/jira/browse/SLING-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687557#comment-16687557
]
Carsten Ziegeler commented on SLING-8104:
-----------------------------------------
Yes, the mechanism needs to be based on the artifact gavs; I think your
proposal makes sense
The only thing is naming, we already have a similar approach for variables and
framework properties. However in the configuration these are just called
"variables" and "frameworkProperties" . In the code we call it overwrites.
So I suggest we go with
variablesOverwrites
frameworkPropertiesOverwrites
artifactsOverwrites
or pick a different word for "Overwrites" - but I hthink we should use the same
naming
In addition your syntax above does not work in XML as a colon is separating
namespace from the element name.
> Avoid magic when merging features
> ---------------------------------
>
> Key: SLING-8104
> URL: https://issues.apache.org/jira/browse/SLING-8104
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
> Reporter: Carsten Ziegeler
> Assignee: David Bosschaert
> Priority: Blocker
> Fix For: slingfeature-maven-plugin 1.0.0, Feature Model 0.2.2
>
>
> Currently when features are merged a simple algorithm is applied which just
> picks the highest version based on the artifact version. However this version
> might not have no meaning at all and might not really reflect what has
> changed inside the bundle.
> Especially when there is a major version change, this approach seems to be
> clearly wrong
> But in the end, picking a single version is magic.
> While the problem could probably be solved by using something like a resolver
> and figure out if just one version is enough or if both versions are needed,
> without a resolver there is no way to figure this out.
> Therefore we should provide a similar way as we do for variables at the
> moment: if there is a clash the caller needs to provide context on what to
> choose.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
