trekawek commented on a change in pull request #21: Implement missing launchpad
services.
URL: https://github.com/apache/sling-whiteboard/pull/21#discussion_r236216793
##########
File path:
startupmanager/src/main/java/org/apache/sling/launchpad/startupmanager/Activator.java
##########
@@ -37,40 +39,30 @@
private static final Logger log = LoggerFactory.getLogger(Activator.class);
- private ServiceRegistration<?> mbeanServerReg;
-
- private ServiceRegistration<StartupListener> mbeanStartupListenerReg;
-
private StartupListenerTracker startupListenerTracker;
@Override
public void start(final BundleContext bundleContext) {
startupListenerTracker = new StartupListenerTracker(bundleContext);
- mbeanServerReg = registerMBeanServer(bundleContext);
Review comment:
Don't we need to unregister all the created services?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
