JEBailey commented on a change in pull request #1: Sling 3270
URL:
https://github.com/apache/sling-org-apache-sling-commons-html/pull/1#discussion_r239065378
##########
File path: pom.xml
##########
@@ -37,25 +37,36 @@
<properties>
<sling.java.version>8</sling.java.version>
- <org.ops4j.pax.exam.version>4.11.0</org.ops4j.pax.exam.version>
+ <org.ops4j.pax.exam.version>4.12.0</org.ops4j.pax.exam.version>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
<project.resources.sourceEncoding>UTF-8</project.resources.sourceEncoding>
</properties>
<scm>
<connection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git</connection>
<developerConnection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git</developerConnection>
<url>https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-commons-html.git</url>
- <tag>HEAD</tag>
- </scm>
+ <tag>HEAD</tag>
+ </scm>
<build>
<plugins>
<plugin>
- <groupId>biz.aQute.bnd</groupId>
- <artifactId>bnd-maven-plugin</artifactId>
Review comment:
The baselining seems to be working differently between the two plugins. I'm
still gathering information between other tasks, but it looks like the bnd
version isn't taking the baseline from the bundle name rather than the
package-info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
