Hi Radu, I don't really understand the fix in https://github.com/apache/sling-org-apache-sling-servlets-annotations/commit/9cc022fa517a858e96229e8629b0102914abb435 <https://github.com/apache/sling-org-apache-sling-servlets-annotations/commit/9cc022fa517a858e96229e8629b0102914abb435>. The previous default (i.e. null) should lead to the fact that the service property is not generated if there is no value set. Now the property is always generated! The former seems to be the more correct approach. Especially if I want to generate servlets targeting pre 2.5.0 servlet resolver. Can you explain?
Thanks, Konrad > On 13. Dec 2018, at 19:27, Radu Cotescu <[email protected]> wrote: > > I’ve realised there was a tiny bug in Apache Sling Servlet Annotations 1.2.0, > which I’ve fixed in the staged Apache Sling Servlet Annotations 1.2.2. Sorry > for that. > > Staging repositories: > https://repository.apache.org/content/repositories/orgapachesling-2027 > <https://repository.apache.org/content/repositories/orgapachesling-2027> - > org.apache.sling.api-2.20.0 (needs to be installed first if you’re going to > check the builds) > https://repository.apache.org/content/repositories/orgapachesling-2028 > <https://repository.apache.org/content/repositories/orgapachesling-2028> - > org.apache.sling.servlets.resolver-2.5.0; PLEASE IGNORE > org.apache.sling.servlets.annotations-1.2.0 > https://repository.apache.org/content/repositories/orgapachesling-2029 - > org.apache.sling.servlets.annotations-1.2.2 > > Thanks, > Radu > >> On 13 Dec 2018, at 19:09, Radu Cotescu <[email protected]> wrote: >> >> +1 >> >>> On 13 Dec 2018, at 19:08, Radu Cotescu <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> Please vote to approve this release: >>> >>> [ ] +1 Approve the release >>> [ ] 0 Don't care >>> [ ] -1 Don't release, because ... >>> >>> This majority vote is open for at least 72 hours. >> >
