kwin commented on a change in pull request #1: Sling 3270
URL:
https://github.com/apache/sling-org-apache-sling-commons-html/pull/1#discussion_r247569311
##########
File path: pom.xml
##########
@@ -37,25 +37,36 @@
<properties>
<sling.java.version>8</sling.java.version>
- <org.ops4j.pax.exam.version>4.11.0</org.ops4j.pax.exam.version>
+ <org.ops4j.pax.exam.version>4.12.0</org.ops4j.pax.exam.version>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
<project.resources.sourceEncoding>UTF-8</project.resources.sourceEncoding>
</properties>
<scm>
<connection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git</connection>
<developerConnection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git</developerConnection>
<url>https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-commons-html.git</url>
- <tag>HEAD</tag>
- </scm>
+ <tag>HEAD</tag>
+ </scm>
<build>
<plugins>
<plugin>
- <groupId>biz.aQute.bnd</groupId>
- <artifactId>bnd-maven-plugin</artifactId>
Review comment:
Actually bnd-baseline-maven-plugin is more correct than maven-bundle-plugin.
Please compare with
https://www.osgi.org/wp-content/uploads/SemanticVersioning.pdf:
> Requiring another bundle is similar to a short form of importing all the
exported packages of that required
bundle. The version of a bundle must therefore semantically aggregate the
semantics of all its constituent
packages. If any of these packages is incompatible with its providers then
the bundle version must increment
the minor version. If any of these packages is incompatible with consumers,
the bundle version must
increment the major version. It is clear, that on average, the version of a
bundle will be much more volatile
than the versions of its constituent packages, increasing the dependency
problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
