Hi, On Wed, Jan 16, 2019 at 6:28 AM Daniel Klco <[email protected]> wrote: > ...I've created pull requests to add the necessary changes to the RepoInit > Parser[2] and JCR RepoInit[3]...
Thank you for this! It all looks good to me, your patches are consistent with the current style of the language and code which is great. One very minor thing, in CreateGroupsTest the createUserWithPathTest method should be named createGroup... IMO you can go ahead, create a jira ticket and commit this. -Bertrand > 2 - https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/2 > 3 - https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/4
