[ 
https://issues.apache.org/jira/browse/SLING-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-8239:
-----------------------------------
    Description: 
With SLING-5940 the {{I18NFilter}} is registered as Filter with the OSGi HTTP 
whiteboard but still in addition as Sling Filter (compare with 
https://github.com/apache/sling-org-apache-sling-i18n/commit/f770fe132ce0cbdab3cae980ac01298bb7baf10d).
That leads to the fact that the filter is being called at least twice for a 
very simple request. Once first via the OSGi HTTP Whiteboard and then from the 
Sling Main Servlet as Sling-specific REQUEST filter.

[~cziegeler] Do we still need to register this filter as Sling filter or is 
HTTP Whiteboard sufficient. I am not sure though about the "ERROR" scope.

  was:
With SLING-5940 the {{I18NFilter}} is registered as Filter with the OSGi HTTP 
whiteboard but still in addition as Sling Filter (compare with 
https://github.com/apache/sling-org-apache-sling-i18n/commit/f770fe132ce0cbdab3cae980ac01298bb7baf10d).
That leads to the fact that the filter is being called at least twice for a 
very simple request. Once first via the OSGi HTTP Whiteboard and then from the 
Sling Main Servlet as Sling-specific REQUEST filter.

[~cziegeler] Do we still need to register this filter as Sling filter or is 
HTTP Whiteboard sufficient. I am no sure though about the "ERROR" scope.


> SlingI18nFilter is executed too often per request
> -------------------------------------------------
>
>                 Key: SLING-8239
>                 URL: https://issues.apache.org/jira/browse/SLING-8239
>             Project: Sling
>          Issue Type: Improvement
>          Components: i18n
>    Affects Versions: i18n 2.5.0
>            Reporter: Konrad Windszus
>            Priority: Major
>
> With SLING-5940 the {{I18NFilter}} is registered as Filter with the OSGi HTTP 
> whiteboard but still in addition as Sling Filter (compare with 
> https://github.com/apache/sling-org-apache-sling-i18n/commit/f770fe132ce0cbdab3cae980ac01298bb7baf10d).
> That leads to the fact that the filter is being called at least twice for a 
> very simple request. Once first via the OSGi HTTP Whiteboard and then from 
> the Sling Main Servlet as Sling-specific REQUEST filter.
> [~cziegeler] Do we still need to register this filter as Sling filter or is 
> HTTP Whiteboard sufficient. I am not sure though about the "ERROR" scope.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to