bosschaert commented on issue #22: SLING-8253 - Make the APIs JARs source 
collector able to checkout SCMs if -sources artifacts are not available
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/22#issuecomment-458143659
 
 
   Hi @simonetripodi - thanks for the pull request. Since there is quite a bit 
of logic in the PR, I would really recommend to add some unit tests. Maybe you 
can isolate the logic into separate methods and write unit tests for these?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to