DominikSuess commented on a change in pull request #1: SLING-8284 - updating
parent pom & eliminating dependency on JcrResou…
URL:
https://github.com/apache/sling-org-apache-sling-resourcecollection/pull/1#discussion_r259295985
##########
File path:
src/main/java/org/apache/sling/resource/collection/impl/ResourceCollectionManagerImpl.java
##########
@@ -93,14 +92,14 @@ public ResourceCollection createCollection(Resource
parentResource, String name,
properties = new HashMap<>();
}
- if
(properties.get(JcrResourceConstants.SLING_RESOURCE_TYPE_PROPERTY) != null
- &&
!ResourceCollection.RESOURCE_TYPE.equals(properties.get(JcrResourceConstants.SLING_RESOURCE_TYPE_PROPERTY)))
{
+ if (properties.get(ResourceResolver.PROPERTY_RESOURCE_TYPE) != null
+ &&
!ResourceCollection.RESOURCE_TYPE.equals(properties.get(ResourceResolver.PROPERTY_RESOURCE_TYPE)))
{
properties.put(
- JcrResourceConstants.SLING_RESOURCE_SUPER_TYPE_PROPERTY,
+ "sling:resourceSuperType",
Review comment:
@rombert great - somehow missed the SlingConstants - thx for pointing out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services