kwin commented on a change in pull request #2: [SLING-8272] Check if Caconfig
Node Exists in JCR
URL:
https://github.com/apache/sling-org-apache-sling-caconfig-api/pull/2#discussion_r263987734
##########
File path: src/main/java/org/apache/sling/caconfig/ConfigurationBuilder.java
##########
@@ -86,4 +86,11 @@
*/
@NotNull <T> Collection<T> asAdaptableCollection(@NotNull Class<T> clazz);
+ /**
+ * Check if the configuration node is existing
+ * @param clazz Class that can be adapted from a {@link
org.apache.sling.api.resource.Resource}
+ * @param <T> Annotation class type
+ * @return True/False based on configuration resource node existence in
JCR.
+ */
+ @NotNull <T> boolean has(@NotNull Class<T> clazz);
Review comment:
You need to extend the javadoc for „name“ as well, as setting the name is
optional for this method as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
