[
https://issues.apache.org/jira/browse/SLING-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792634#comment-16792634
]
Konrad Windszus commented on SLING-8316:
----------------------------------------
Actually the version of the ConfigurationHandler was upgraded with
https://github.com/apache/sling-org-apache-sling-installer-core/commit/76f22c5a41476616877638161390076b2a963942
from 1.2.8 to 1.8.6 and later to 1.8.12 (SLING-4793). At the same time the
write back only used 1.2.8.
Actually the fix in
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/commit/b00d3e47fb5802eb2ddc4610bfc92906d7ec8a8e
is not sufficient to fix the problem, as the old version of installer.core
being referenced in
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/blob/b7c30d54b8c732035f6ab81f10927df6753dee79/pom.xml#L96
only provides version 1.2.8 but not the newer 1.8.12.
> Use the same version of o.a.felix.cm.file.ConfigurationHandler in
> installer.core and installer.provider.jcr
> -----------------------------------------------------------------------------------------------------------
>
> Key: SLING-8316
> URL: https://issues.apache.org/jira/browse/SLING-8316
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: JCR Installer 3.1.26
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Minor
> Fix For: JCR Installer 3.1.28
>
>
> The {{o.a.felix.cm.file.ConfigurationHandler}} is used in two different
> bundles:
> # installer.core in
> https://github.com/apache/sling-org-apache-sling-installer-core/blob/7b2e4407baa45b79d954dd20c53bb2077c3a5e49/src/main/java/org/apache/sling/installer/core/impl/InternalResource.java#L230
> to read from .config files
> # installer.provider.jcr in
> https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/blob/c5827d05742bdee4fe2ffdb410616be2d9f63850/src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java#L710
> for the write back feature
> Both use quite different versions of the Felix ConfigurationHandlen and even
> worse, the classpath of installer.provider.jcr contains
> {{o.a.felix.cm.file.ConfigurationHandler}} twice (once as embedded package of
> the installer.core bundle and once as direct dependency).
> Instead the JCR Installer Provider Write Back should always use the version
> from the OSGi Installer Core bundle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
