[
https://issues.apache.org/jira/browse/SLING-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-8316:
-----------------------------------
Description:
The {{o.a.felix.cm.file.ConfigurationHandler}} is used in two different bundles:
# installer.core in
https://github.com/apache/sling-org-apache-sling-installer-core/blob/7b2e4407baa45b79d954dd20c53bb2077c3a5e49/src/main/java/org/apache/sling/installer/core/impl/InternalResource.java#L230
to read from .config files
# installer.provider.jcr in
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/blob/c5827d05742bdee4fe2ffdb410616be2d9f63850/src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java#L710
for the write back feature
Both use quite different versions of the Felix ConfigurationHandlen and even
worse, the classpath of installer.provider.jcr contains
{{o.a.felix.cm.file.ConfigurationHandler}} twice (once as embedded package of
the installer.core bundle and once as direct dependency).
Instead the JCR Installer Provider Write Back should always use the version
from the OSGi Installer Core bundle.
Using a newer version for the writeback particularly allows to write better
multivalue entries which are easier to diff (compare with SLING-4793 and
was:
The {{o.a.felix.cm.file.ConfigurationHandler}} is used in two different bundles:
# installer.core in
https://github.com/apache/sling-org-apache-sling-installer-core/blob/7b2e4407baa45b79d954dd20c53bb2077c3a5e49/src/main/java/org/apache/sling/installer/core/impl/InternalResource.java#L230
to read from .config files
# installer.provider.jcr in
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/blob/c5827d05742bdee4fe2ffdb410616be2d9f63850/src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java#L710
for the write back feature
Both use quite different versions of the Felix ConfigurationHandlen and even
worse, the classpath of installer.provider.jcr contains
{{o.a.felix.cm.file.ConfigurationHandler}} twice (once as embedded package of
the installer.core bundle and once as direct dependency).
Instead the JCR Installer Provider Write Back should always use the version
from the OSGi Installer Core bundle.
> Use the same version of o.a.felix.cm.file.ConfigurationHandler in
> installer.core and installer.provider.jcr
> -----------------------------------------------------------------------------------------------------------
>
> Key: SLING-8316
> URL: https://issues.apache.org/jira/browse/SLING-8316
> Project: Sling
> Issue Type: Improvement
> Components: Installer
> Affects Versions: JCR Installer 3.1.26
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Minor
> Fix For: JCR Installer 3.1.28
>
>
> The {{o.a.felix.cm.file.ConfigurationHandler}} is used in two different
> bundles:
> # installer.core in
> https://github.com/apache/sling-org-apache-sling-installer-core/blob/7b2e4407baa45b79d954dd20c53bb2077c3a5e49/src/main/java/org/apache/sling/installer/core/impl/InternalResource.java#L230
> to read from .config files
> # installer.provider.jcr in
> https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/blob/c5827d05742bdee4fe2ffdb410616be2d9f63850/src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java#L710
> for the write back feature
> Both use quite different versions of the Felix ConfigurationHandlen and even
> worse, the classpath of installer.provider.jcr contains
> {{o.a.felix.cm.file.ConfigurationHandler}} twice (once as embedded package of
> the installer.core bundle and once as direct dependency).
> Instead the JCR Installer Provider Write Back should always use the version
> from the OSGi Installer Core bundle.
> Using a newer version for the writeback particularly allows to write better
> multivalue entries which are easier to diff (compare with SLING-4793 and
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
