[ 
https://issues.apache.org/jira/browse/SLING-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Ka Sing Li updated SLING-8377:
------------------------------------
    Description: 
After testing out Sling Dynamic Include 3.1.2, it seems like setting an option 
(include-filter.config.selector) to BLANK is not supported.

Scenario:
 AEM 6.4.2, after installing Dynamic Include, I will configure the OSGI 
configuration. With an option of an input field 
(include-filter.config.selector) set to blank, my rendered page received a 
double dot notation. 

*Actual* (notice the double dot notation) :
{code:java}
${root}/resource/path..html
{code}
*Expected :*
{code:java}
${root}/resource/path.html
{code}

{color:#FF0000}*Conclusion :*{color}
I've created a branch and tried to create a pull request, but I am not 
authorized to do so. Please see attached files for the solution to this 
problem. 
 [^UrlBuilder.java]
 [^UrlBuilderTest.java]

I've also included new unit tests Supporting :
{code:java}
UnsetRequestPathInfoSelector UnsetIncludeSelector{code}
{code:java}
SetRequestPathInfoSelector UnsetIncludeSelector{code}
{code:java}
UnsetRequestPathInfoSelector SetIncludeSelector
{code}
 

 

  was:
After testing out Sling Dynamic Include 3.1.2, it seems like setting an option 
(include-filter.config.selector) to BLANK is not supported.

Scenario:
AEM 6.4.2, after installing Dynamic Include, I will configure the OSGI 
configuration. With an option of an input field 
(include-filter.config.selector) set to blank, my rendered page received a 
double dot notation. 



Actual (notice the double dot notation)

 
{code:java}
${root}/resource/path..html
{code}
Expected

 

 
{code:java}
${root}/resource/path.html
{code}

I've also included new unit tests Supporting :
{code:java}
UnsetRequestPathInfoSelector UnsetIncludeSelector{code}
{code:java}
SetRequestPathInfoSelector UnsetIncludeSelector{code}
{code:java}
UnsetRequestPathInfoSelector SetIncludeSelector
{code}
 


I've created a branch and tried to create a pull request, but I am not 
authorized to do so. Please see attached files for the solution to this 
problem. 
[^UrlBuilder.java]
[^UrlBuilderTest.java]

 


> Sling Dynamic Include - Does not support empty "include selector" option.
> -------------------------------------------------------------------------
>
>                 Key: SLING-8377
>                 URL: https://issues.apache.org/jira/browse/SLING-8377
>             Project: Sling
>          Issue Type: Bug
>    Affects Versions: Dynamic Include 3.1.2
>            Reporter: Brian Ka Sing Li
>            Priority: Critical
>         Attachments: UrlBuilder.java, UrlBuilderTest.java
>
>
> After testing out Sling Dynamic Include 3.1.2, it seems like setting an 
> option (include-filter.config.selector) to BLANK is not supported.
> Scenario:
>  AEM 6.4.2, after installing Dynamic Include, I will configure the OSGI 
> configuration. With an option of an input field 
> (include-filter.config.selector) set to blank, my rendered page received a 
> double dot notation. 
> *Actual* (notice the double dot notation) :
> {code:java}
> ${root}/resource/path..html
> {code}
> *Expected :*
> {code:java}
> ${root}/resource/path.html
> {code}
> {color:#FF0000}*Conclusion :*{color}
> I've created a branch and tried to create a pull request, but I am not 
> authorized to do so. Please see attached files for the solution to this 
> problem. 
>  [^UrlBuilder.java]
>  [^UrlBuilderTest.java]
> I've also included new unit tests Supporting :
> {code:java}
> UnsetRequestPathInfoSelector UnsetIncludeSelector{code}
> {code:java}
> SetRequestPathInfoSelector UnsetIncludeSelector{code}
> {code:java}
> UnsetRequestPathInfoSelector SetIncludeSelector
> {code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to