raducotescu edited a comment on issue #3: SLING-8425 - Fix NPE on GraalVM URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/3#issuecomment-494504655 @paul-bjorkstrand, I'm working on a slightly improved version of your test. The way you wrote it made it fail consistently on my machine, with both Java 8 and Java 11. However, `org.apache.sling.scripting.core.impl.jsr223.SlingScriptEngineManagerTest#testBundledScriptEngineFactory` fails on Java 11, but passes on Java 8. That's because the `ServiceLoader` obtained from the bundle's classloader will already have access to the `ScriptEngineFactories` provided by the platform, which will, in turn, duplicate the number of engines provided by the platform in the `org.apache.sling.scripting.core.impl.jsr223.SlingScriptEngineManager#factories`. I'll push my changes tomorrow morning - I'm on the CEST timezone.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
