[
https://issues.apache.org/jira/browse/SLING-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855386#comment-16855386
]
Konrad Windszus edited comment on SLING-5726 at 6/4/19 7:02 AM:
----------------------------------------------------------------
There once was an AdapterFactory which allowed to adapt directly a Request to a
ValueMap (and in fact took the request parameters as source, instead of the
request's resource). For more details refer to
https://issues.apache.org/jira/browse/SLING-5590. I don't think this is an
issue though, as long as we try adaptations first and only if that fails fall
back to the resource's value map. Also that adaptation was only shipped with a
SNAPSHOT version of Sling Validation once and is no longer part of any released
Sling bundles.
was (Author: kwin):
There once was an AdapterFactory which allowed to adapt directly a Request to a
ValueMap (and in fact took the request parameters as source, instead of the
request's resource). For more details refer to
https://issues.apache.org/jira/browse/SLING-5590. I don't think this is an
issue though, as long as we try adaptations first and only if that fails fall
back to the resource's value map.
> Allow ValueMapInjector and ResourcePathInjector to act directly on
> SlingHttpServletRequest
> ------------------------------------------------------------------------------------------
>
> Key: SLING-5726
> URL: https://issues.apache.org/jira/browse/SLING-5726
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Sling Models Impl 1.2.8
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Attachments: SLING-5726.patch
>
>
> Currently both injectors only work correctly on objects being adaptable to a
> {{ValueMap}}. For {{ValueMapInjector}} this is documented but for
> {{ResourcePathInjector}} it is not
> (http://sling.apache.org/documentation/bundles/models.html#available-injectors),
> although for the latter it does only matter if the path is given through a
> resource property and not in a static way.
> This should be relaxed that both also work with {{SlingHttpServletRequest}}
> as that always carries the current resource from which the {{ValueMap}} can
> be easily retrieved.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
