stefanseifert commented on a change in pull request #13: SLING-8452 migrate to OSGi annotations URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/13#discussion_r290917263
########## File path: src/main/java/org/apache/sling/models/impl/FirstImplementationPicker.java ########## @@ -31,9 +29,7 @@ * But at least it gives a consistent behavior. * It's service ranking is set to the highest value to allow more intelligent implementations to step in. */ -@Component -@Service -@Property(name = Constants.SERVICE_RANKING, intValue = Integer.MAX_VALUE) +@Component(property=Constants.SERVICE_RANKING+":Integer="+Integer.MAX_VALUE) Review comment: cosmetic: also not explicitly required i personally prefer to add an explicit service=ImplementationPicker.class attribute to make it clear that this is an OSGi service and not only a component. (same case may apply to other services as well) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
