Hi, I realise that this module provides a catch-all last-resort solution, which definitely has its place. Especially if the code without timeouts is not within our control.
So just as an FYI, some time ago I implemented OSGi configuration support for HttpClient 4.x, which allows having pre-configured HttpClient instances injected (or preconfigured HttpClientBuilderFactory instances for more complex use-cases). The docs and code are at https://github.com/code-distillery/httpclient-configuration-support. Regards Julian On Tue, Jun 18, 2019 at 12:03 PM Stefan Seifert <[email protected]> wrote: > > makes sense, i'm fine with it. > > stefan > > >-----Original Message----- > >From: Robert Munteanu [mailto:[email protected]] > >Sent: Tuesday, June 18, 2019 11:47 AM > >To: [email protected] > >Subject: Re: [git] New git repository - sling-org-apache-sling-connection- > >timeout-agent > > > >Hi Stefan, > > > >On Tue, 2019-06-18 at 08:47 +0000, Stefan Seifert wrote: > >> sounds reasonable > >> (although i'm always a bit hesitent with such low-level > >> instrumentation magic - if this magic creates a problem sometimes in > >> the future it's quite difficult to find out what's the source of the > >> problem if you are not aware of the presence of it) > > > >I agree and I'm looking at this as a last resort. If you run code you > >can't control which is also not setting timeouts you basically have > >three options: > > > >1. try and get the code fixed (might not always be possible or simple) > >2. Live with possible downtime due to missing timeouts > >3. Apply a little bit of magic and get more stability > > > >Up till now we only had 1 and 2. This new module add option 3. > > > >Note that I don't think anyone should just apply this for their Sling > >deployments unless they think they have a real need for it. > > > >If you own the code, you should 100% apply timeouts yourself. This is > >for code you're running but not controlling. > > > >> > >> the README is missing the "OkHttp" support. > > > >Added in https://github.com/apache/sling-whiteboard/pull/42 , thanks! > > > >Robert > > > >> > >> stefan > >> > >> > -----Original Message----- > >> > From: Robert Munteanu [mailto:[email protected]] > >> > Sent: Tuesday, June 18, 2019 10:12 AM > >> > To: [email protected] > >> > Subject: [git] New git repository - sling-org-apache-sling- > >> > connection- > >> > timeout-agent > >> > > >> > Hi, > >> > > >> > I'd like to create a new repo for the code currently living in the > >> > whiteboard at [0]. > >> > > >> > Proposed repository name: sling-org-apache-sling-connection- > >> > timeout-agent > >> > Artifact id: org.apache.sling.connection-timeout-agent > >> > > >> > The resulting jar file will be a java agent (and probably _not_ and > >> > OSGi bundle ) that is used to set timeout defaults for HTTP > >> > connections > >> > made from within a Sling application. > >> > > >> > The README [1] has more details on requirements, supported features > >> > and > >> > usage. > >> > > >> > Thoughts? > >> > > >> > Robert > >> > > >> > [0]: > >> > https://github.com/apache/sling-whiteboard/tree/master/url-connection > >> > - > >> > agent > >> > [1]: > >> > https://github.com/apache/sling-whiteboard/blob/master/url-connection > >> > - > >> > agent/README.md > >> > > > >
