badvision commented on a change in pull request #40: Renaming to Sling Model
Persist, fixed test error with JDK 11
URL: https://github.com/apache/sling-whiteboard/pull/40#discussion_r296944124
##########
File path:
SlingModelPersist/src/main/java/org/apache/sling/models/persist/ModelPersist.java
##########
@@ -1,21 +1,21 @@
-package org.apache.sling.models.persist;
-
-import javax.jcr.RepositoryException;
-import org.apache.sling.api.resource.PersistenceException;
-import org.apache.sling.api.resource.ResourceResolver;
-import org.jetbrains.annotations.NotNull;
-
-/**
- * Definition of JCR Persist service
- */
-public interface JcrPersist {
-
- void persist(@NotNull Object object, @NotNull ResourceResolver
resourceResolver) throws RepositoryException, PersistenceException,
IllegalArgumentException, IllegalAccessException;
-
- void persist(@NotNull Object object, @NotNull ResourceResolver
resourceResolver, boolean deepPersist) throws RepositoryException,
PersistenceException, IllegalArgumentException, IllegalAccessException;
-
- void persist(String nodePath, @NotNull Object object, @NotNull
ResourceResolver resourceResolver) throws RepositoryException,
PersistenceException, IllegalArgumentException, IllegalAccessException;
-
- void persist(String nodePath, @NotNull Object object, @NotNull
ResourceResolver resourceResolver, boolean deepPersist) throws
RepositoryException, PersistenceException, IllegalArgumentException,
IllegalAccessException;
-
-}
+package org.apache.sling.models.persist;
+
+import javax.jcr.RepositoryException;
+import org.apache.sling.api.resource.PersistenceException;
+import org.apache.sling.api.resource.ResourceResolver;
+import org.jetbrains.annotations.NotNull;
+
+/**
+ * Definition of JCR Persist service
+ */
+public interface ModelPersist {
Review comment:
Well I think you might be right. Class names work better as nouns, and this
is more verb-y. ModelPersistor is something which persists models, maybe
that's a better name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
